bibo38

Results 17 comments of bibo38

@antoniomika bump and I think, that @santomet cannot reopen the PR by himself

Just for the naming I would prefer `NBTTree`, because I thought first, that you would add NBT data to a tree 🤣 .

> Note that your fixes still aren't perfect - the part after the prefix should be capitalized: a_Tolua_s (or even better, a_LuaState), a_ArgP, a_Args, a_Status ... Yep, I know. But...

> It's not going to increase the line count if it's only changing the same variable names. ```bash $ grep -R -E 'a_[a-z]' src/ | wc -l 25628 ``` Or...

Yep, just figured that out myself... all of these `a_tolua_S`.

```bash $ grep -R -E '[^a-zA-Z_]a_[a-z]' --exclude=Bindings.cpp src/ | wc -l 269 ``` Should be possible in this PR :smile_cat: P.S.: Should I ignore the generated binding files for `clang-tidy`...

I would also request the feature of forcing the client to use a texture pack(e.g. kicking the player, when the texture pack is not accepted/loaded). It doesn't need to be...

> Add a new cPlayer member variable and getter (+Lua API) specifying what the client responded in the Resource Pack Status packet (ok, failed, declined; what is "accepted"?) I would...

> It'd be easier for Cuberite to periodically check the URL and recalculate the SHA1, say, every hour or so. @madmaxoft What do you mean by checking the URL? Checking...

I don't really know about any special documentation about the database and it's tables. Is there anything special you wanna find/change in the database? In practice the best documentation for...