Bhumit Attarde
Bhumit Attarde
> @bhumitattarde could you please have a look why the docs-html build step has failed for this PR? Doxygen/Sphinx seem to be thinking ```cpp template explicit annotating_executor(BaseExecutor&& sched, std::string annotation)...
Hey. thank you for reporting this. I'll take a look and update here. Unfortunately, IIRC, std::isnan() gives compilation errors on Windows. I'll have to find some other way.
#44 should work as long as the compiler doesn't optimize the comparison. I realize this is fragile but right now, it seems to be the best way to move forward...
You seem to be correct. I'll check this.
This will be fixed in [`v2`](https://github.com/zerodha/cppkiteconnect/tree/v2).
`isValid` is phased out in `v2`.
@adithyaakrishna Sure, good luck!
@it4ch11 yes : )
> @bhumitattarde, would it be possible to share a few steps to review this? Skip the `Files Changed` tab and browse the branch directly. Focus on the `kitepp` directory. You've...
@rhnvrm @ajinasokan I don't have any more changes to make. Can we merge this if there's nothing to add?