Brian Hough

Results 14 comments of Brian Hough

@EnesAppsmen Similar to #550 this is a bug with our Flow > TS library. We will be moving to native TS in v5 and will address this then.

Verified this is the case. However, this difference holds true all the way back to polished v1.0. We need to do some more investigation into where the formula is different...

@jzempel Thank you for bringing this to our attention. We were missing a TS test for this scenario. Unfortunately, the library we use for generating types for TS is fairly...

@MrLoh We'd definitely be interested in adding HCL color space and are open to PRs/Discussion on the best way to do so.

@MrLoh we definitely don't want to add any external dependencies. Also our color methods work differently than chroma.js as ours are more functional (composable) where theirs take a more object...

@MrLoh All our color methods are composable like this: ```javascript const pastelize = compose( tint(0.3) lighten(0.3) saturate(0.2) ) pastelize('#F00') ``` One of the main reasons we don't go object-oriented like...

@sayjeyhi polished is fully tree-shakeable and has been for a couple years now. FWIW I don't think Bundlephobia is evidence that something isn't properly tree-shakeable. Here is another example where...

@avin-kavish This is still an open issue @sayjeyhi is just suggesting an interim solution. We've been unable to recreate this yet. If you'd like to provide the info we asked...

@sayjeyhi All we really need is a link to a repo we can fork that shows where it isn't tree-shaking and can take it from there.

![image](https://user-images.githubusercontent.com/769339/79701464-4ccf7f80-826b-11ea-9bb4-b43255a47ef4.png) @sayjeyhi the screenshot is `lighten` and `darken` using a basic CRA app out of the box. The first difference I see is your build is pulling from `lib` where...