bgbsww

Results 184 comments of bgbsww

See https://github.com/vlachoudis/bCNC/pull/1772 for G2core support that might work with TinyG. I can't test that case.

Seems like there might be an opportunity to clean up FeaturePipe and/or share code between these two, but that's beyond the scope of fixing this problem.

This is noticably faster than the code it replaces in the UI. Is there a formal test I need to run? I will take a look at another PR for...

I no longer see a good opportunity to share with FeaturePipe: too many MakePipeShell specific options are exposed in the UI, so I would either have to switch Helix back...

Thanks, @FlachyJoe you beat me to it. That solves the three example files for me. I'm ~~trying~~ tried to confirm the other bug cases @adrianinsaval noted, but was unable to...

``` OS: Ubuntu 22.04.3 LTS (ubuntu:GNOME/ubuntu) Word size of FreeCAD: 64-bit Version: 0.22.0dev.35265 (Git) Build type: Debug Branch: bgbsww-patch-16 Hash: b5862a781b480b85aebd57cda496375c1a09c08c Python 3.10.12, Qt 5.15.3, Coin 4.0.0, Vtk 7.1.1, OCC...

Hrm. Maybe I was recomputing wrong? I can duplicate the effect now, so something to chase. Let me see if I can get to equiv results, but if not, then...

That seems like a good path forward to me. ~~Note that when I go back to the prior code, on recompute I get the correct relative position, but I do...

The UseMakePipe for this patch also solves what #11399 solved, because that was all about trying to work around bugs in MakePipeShell; once we switch to MakePipe for new objects,...

OK! Now I think it's really and truly done. My oversight that led to the positioning issue should be fixed. A whole lot of credit goes to wwmayer FlachyJoe and...