Joseph Huang

License?

2

Which license is this available under?

Without this, it fails to compile with PGM-index/include/pgm/morton_nd.hpp:59:11: error: ‘uint64_t’ does not name a type

Please add: mkdir build to the documentation, or else make silently does nothing. Also, it is unclear how to actually compile and run the emitted code. The examples seem to...

update to support llvm-10

2

This fixes compiling against llvm 10.0.1 Also adds build directory to .gitignore If this request is merged, I can also update the documentation.

option to remove comments

1

Add an option to remove comments. This will help make clear that development is supposed to happen on the non-combined file. You could keep comments that start with ! to...

noexcept

2

Please make an option to make this not throw exceptions. Throwing exceptions forces changes to the code or to enable exceptions which can impact performance.

This fixes compile for tests and examples for me on gcc 13.2.0 Ubuntu 23.10

Please add a way to disable the internal mixing.

Any comments on this paper? Maybe the improvements could be upstreamed here? https://arxiv.org/abs/2410.00846 https://github.com/qyliu-hkust/bench_search

constructive collisions

6

Please add a mode where hash collisions are allowed if two different keys have the same value stored in the table.