Bob Forma comments

Results 15 comments of


                                            Bob Forma

Fix `FrozenError`s

If you mean `# frozen_string_literal: true`, then yes.

Fix `FrozenError`s

We are running with Ruby 2.6.5. All of our Ruby source files have the `# frozen_string_literal: true` magic comment. Some of our tests failed due to a `FrozenError: can't modify...

Fix `FrozenError`s

I just noticed that our failing tests define a `String` literal and (indirectly) pass that to `CombinePDF.parse`. Just doing a `.dup` on those `String`s in the tests already fix the...

[feature] define after_initialize callback in sequent command

I'm not sure if this is the way to go for 'default' values. We could also introduce the following: ```ruby MyCommand < Sequent::Command attr flag: Boolean, default: true end ```...

Implement command middleware

> I like the use of Middleware of the filters we currently use. This is also more inline with how e.g. Rack works with Middleware. We should add documentation for...

Implement command middleware

Any word on this? We could use this.

Implement command middleware

Sure.

Implement command middleware

Can this be merged now?

Undefine allocation function for C extension class

Any update on this? I've tried this and it works for us. The warning is no longer shown.

Show environment in dashboard (UI)

Yes, the secondary navbar would be a good place to put it 👍 . Why would this need extra custom configuration?