Brian Feister

Results 11 issues of Brian Feister

This GIF is 2.4mb (sorry!) might take a moment to load: ![Screen_Recording_2022-06-28_at_4 41 55_PM](https://user-images.githubusercontent.com/47546998/176316544-0113e41f-6116-4db1-8ff7-cd13234923f1.gif)

# Description # Types of Changes - [ ] **Bug fix** (non-breaking change that fixes an issue) - [ ] **New feature** (non-breaking change that adds functionality) - [ ]...

# Description Adding unit test coverage for PR where it was mentioned by @adamraya : https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1255 # Types of Changes - [ ] **Bug fix** (non-breaking change that fixes an...

# Description Digging into the questions we discussed re: testing (a big one being "how can we throw an error any time a test makes a real network request") I've...

### Duplicates - [X] I have searched the existing issues ### Latest version - [X] I have tested the latest version ### Current behavior 😯 There is a working example...

bug

# Description * [x] Fix 37 errors on the PDP page (unsure why these weren't resolved prior to merging #2517, which appears to require the Product Detail Page load without...

# Description This spike met with a "tragic end" as documented here in the [Quip doc for the spike](https://salesforce.quip.com/pJsuARh3RryS) but adding this PR just as an example / documentation of...

# Description In the new RSC app directory, there are two comparative implementations which are being discussed for the React Router 7 support in PWA Kit. ### Comparative metrics https://docs.google.com/spreadsheets/d/1jJ_EEuq4MPGhdeUbDcfzmrBKZARxYFLB7V2xun4Yv7U/edit?gid=1592550389#gid=1592550389...

# Description Add initial documentation for `pwa-kit-create-app` extensions in EXTENSIONS.md file # Types of Changes - [ ] **Bug fix** (non-breaking change that fixes an issue) - [ ] **New...

skip changelog

# Description Remove dead code that should have be handled in previous PR https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2712 # Types of Changes - [ ] **Bug fix** (non-breaking change that fixes an issue) -...