Beau Fabry

Results 9 comments of Beau Fabry

> If you want the profiles to include information about JNI calls make sure to have any relevant binaries/object files in the directory you run pprof from. Is there any...

Yup, I've added that test and it failed, and I've come up with my version of a fix. It's a bit gross though so let me know if there's a...

Oh, it did it automatically

Oh cool, I assumed it would have. wonder why it's not firing...

@sritchie could you give me a pointer as to where/how the nil filtering should happen? I've been walking through this code today and am struggling.

@sritchie those are both part of the cascading platform, but the bug is with the in-memory platform?

github's inability to notify me about PR's I actually care about continues... sorry for the delay @boymaas we'll look at this

ok, some initial thoughts: First, thank you for submitting a patch! I believe you're right there's a bug here. I don't see how that function could work without something specifying...

> assuming this would add another step in the pipeline, it would make the whole processing pipeline a bit less efficient. If that is the case I would go for...