Vatsal Sanchala

Results 10 comments of Vatsal Sanchala

Hello, I have added the required feature. If the string length falls in the range and if exact number/array/object is mentioned, then exact conditions are checked. If not provided, then...

> Thanks for the updates! I have some additional comments > > And I'll tag @rubiin here as well for the more official review and approval for having `exact` be...

> Keep the old test and then I think we should be good. I'll leave other reviews up to the actual maintainers of this library. Thanks again for working on...

Hello, I have added the required feature. If the string length falls in the range and if exact number/array/object is mentioned, then exact conditions are checked. If not provided, then...

Heyy @rubiin !! This additional feature is been added in PR https://github.com/validatorjs/validator.js/pull/2019. It would be great if you could have a look.

@rubiin @WikiRik @chuyeow @boutell @timoxley Please have the final look.

> Sorry for late review on this. > > I'm struggling to understand the use-case for `exact`. And also why we have as an object or array too. Could you...

@pixelbucket-dev I made all the necessary changes and also synced the branch with the latest commits.

> I was just thinking: A future improvement could be to improve the options API to have consistent fields. This is because, with `discreteLengths`, we have a new field, and...