Vitalii

Results 25 comments of Vitalii

> Mostly look good but names could be a bit more explicit: > > * Since "pacman" is also used by MinGW, could we use "arch-package" instead of "pacman-package"? >...

Same problem on `Arch Linux` distribution: ``` -- The CXX compiler identification is GNU 11.1.0 -- The C compiler identification is GNU 11.1.0 -- The ASM compiler identification is GNU...

`AutoPattern` is just not supported for `TypeCheckDeclaration` with `DeclarationKind::VariableDeclaration` right now. (only `ExpressionPattern`) as I understand.https://github.com/carbon-language/carbon-lang/blob/8c85fa2744f91ce1dee56c1625625af8ba247c43/explorer/interpreter/type_checker.cpp#L3949-L3955 https://github.com/carbon-language/carbon-lang/blob/8c85fa2744f91ce1dee56c1625625af8ba247c43/explorer/interpreter/type_checker.cpp#L4014-L4017 [@geoffromer, @jonmeow], is implementation planed in scope of another issue, or in team...

@quark-zju, ping! Is it still relevant? Requested changes is already implemented.

I can implement it. Contributors, can approve a feature? UPD: Because `func readConfig` uses an already configured logger, we can implement the logic to reconfigure it later.

> @0x4E69676874466F78 It works perfectly fine for Linux, no reason to change it. > > Windows users should not manually edit config files, but use a GUI application wrapper for...

How it looks like at this time: ```go package main import ( "context" "net/netip" "time" "github.com/sagernet/sing-box" "github.com/sagernet/sing-box/option" C "github.com/sagernet/sing-box/constant" ) func main() { boxInstance, err := box.New(box.Options{ Context: context.TODO(), Options:...

@h-grieve I also found a solution for `EOFError` that often occurs in the field (#77). This requires some changes to the `hivemind` library, as the way they handle pipes (used...

@yihualou @h-grieve, these changes are still working for us and our compute cluster. We have done some more testing and can confirm that they work and allow us to launch...

Still working on some minor improvements and bug fixes. I think this change requires better logging for closing outbound, but not all outbound implementations have a close method, which makes...