Bernhard Schmidt

Results 56 comments of Bernhard Schmidt

> One more thing, @bernhard-adobe: the color for the `disabled` variant looks pretty different than it did before (see below with current and previous). Would you mind double-checking on that...

> > One more thing, @bernhard-adobe: the color for the `disabled` variant looks pretty different than it did before (see below with current and previous). Would you mind double-checking on...

rebuild Jenkins: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/37/ VRT results are: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/37/artifact/backstop_data/html_report/index.html

@pfulton color changes (as expected) for disabled and line-height changes (as expected):

Fixed misaligned Field-Label padding for variant Side-Label. @pfulton can you please publish another beta-release for the FieldLabel so I can pull in the latest changes in Web Component and re-run...

VRT test is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/27/

some colors need to be verified just to make sure I followed the correct specs from the XD file `Components Batch 1.xd` VRT Results: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/27/artifact/backstop_data/html_report/index.html

> I don't think there are Express versions needed - works out of the box. Main difference is the emphasized variant fill color

fixed in: https://github.com/adobe/spectrum-css/issues/1433. We just need to update CSS

VRT is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/39 [1501 - swatch.zip](https://github.com/adobe/spectrum-css/files/9410714/1501.-.swatch.zip)