Ben Villalobos comments

Results 119 comments of


                                            Ben Villalobos

ResolvePackageAssets target is skipped for multiple target frameworks and Rebuild target in 17.2.0

MSBuild Team Triage: The targets for this issue don't exist in the msbuild repo. The flags that control the build ordering seem to exist in the SDK repo: `_SdkBeforeRebuild `...

PublishRelease=true in project file doesn't actually change the configuration to "Release" when running "dotnet publish"

Chiming in with a bit of context: We saw that the value of `Configuration` (very early on) determines the values of `Optimize` and `DebugSymbols`. Thankfully, `Optimize` and `DebugSymbols` aren't really...

`dotnet build` returns exit code `1` even when the build passes

It looks like this is specifically happening during `dotnet publish`, not `dotnet build`. It's tough to parse from the logs since I don't look at helix logs often. If you...

`dotnet build` returns exit code `1` even when the build passes

Here's the tree of msbuild commits this scenario is working with: https://github.com/dotnet/msbuild/commits/5d102ae37

`dotnet build` returns exit code `1` even when the build passes

Is there a minimal repro someone can provide for this?

MSBuild task for creating Tar files

In that case, blocked on https://github.com/dotnet/msbuild/pull/7790 and should be conditioned. We can add this to the next spring planning and discuss it then. Conditioning out the task should be easy...

LogErrorFromException could preserve Exception.HelpLink

Does this mean we'd be slowly adding helplinks to most MSBuild errors? Presumably starting with the most popular ones. Related to docs, cc @ghogen

Canceling a build can fail if a process running on the computer is protected

Team Triage: We agree, that shouldn't be fatal. The solution here would be to add a catch for this

MSBuildFileSystemBase is partialy honoured when used to load imports

This seems like a reasonable request. We would need to investigate performance implications here.

MSBuild task with TargetFramework property broke in 17.3

I can successfully repro. Some questions: What version of MSBuild did you update from? Can you provide a binlog of the regressed scenario with the older version of MSBuild? Did...