Ben Trengrove
Ben Trengrove
I haven't been able to reproduce this, have you tried on 1.2.0-rc01?
Thanks for the report. For the proposed solution, wouldn't you still need overscroll for when you hit the bottom of the list?
Oh sorry I misread, it's only while a swipe is in progress. That does seem like a good fix at second glance. Feel free to put up a PR and...
Your logic seems sounds to me. Do all the tests pass? I didn't write this code though so I can't say if this was done on purpose. Don't worry about...
Cool idea, and definitely something that could be good to develop into a general practice for things like this as you say
Thanks for the report, this is definitely something we need to improve. Just as a side note, I wouldn't store a view in the viewmodel, so be careful. That sounds...
I have reproduced this and agree. I think this should be fixed upstream though so have filed a bug and will follow up with the team. I will keep this...
+1 this worked for me.
I'm not 100% sure what you mean sorry. You just extract the state and then assert on it? There are multiple examples of testing isRefreshing in our tests for SwipeRefresh...
Have you tried using a modifier on the composable? If so, which one?