Ben Mehlman
Ben Mehlman
Sorry, it looks like I've messed up the documentation somehow.. but Travis doesn't tell me the actual spelling error... If you could tell me what I've messed up I'll fix...
Ok.. added tests for the new code to test_linkcolumn (in addition, added pass-through of new parameters from LinkColumn to linkify and updated docs for LinkColumn)... All tests pass.
Re `boundrows=None`, _probably_ because I was trying to avoid breaking other people's code in case someone, somewhere, instantiated a BoundRow using the current signature. But I can take that out....
Hi, please don't commit to this branch. I've noticed some problems with it (as you pointed out.. it does not pass all the tests) and I am working on them...
I'm sorry I left this hanging so long, things got super busy here.. then the pandemic. I'm now looking at these patches and wondering whether they are still relevant. If...
So, I worked on this a little bit, and here's my example of an approach that does not change tables2: ``` from django_tables2.columns.base import LinkTransform class LinkTemplate(LinkTransform): def __init__(self, url_name,...
So, I had to go ahead with some kind of solution, so in case anyone's interested here's what I did. First, I created a subclass of tables2's `LinkTransform` that knows...
Thanks for reading through it, I'm happy to write a patch for `LinkTransform`. I have one question there, which is to use six.moves for urllib/urllib2 import? Or forget py2 altogether?...
This adds 'query' and 'fragment' options to `linkify= {}` https://github.com/jieter/django-tables2/pull/711 Hope you will also take a look at my already subsmitted pr for issue #682 which I am currently using...
I thought about this a little more, and I think that, unless there is a specific reason for the counter to be a member of Table, it makes more sense...