Ben Kitzelman comments

Results 6 comments of


                                            Ben Kitzelman

Fix formatting issue so you don't need to gsub

+1 this :)

TypeError: tag[primaryAttributeKey].toLowerCase is not a function with external scripts in reactjs without gatsby

I managed to get round it by not using JSX - this code takes an inlined link or script node, and renders it in the head instead of the body:...

capybara-webkit doesn't work on Heroku

Hi Andrew - thanks for contributing! There is a base class /lib/google_ajax_crawler/drivers/driver.rb ... really all that is needed is to implement the following methods using phantom - visit(url) - default_page_loaded_test...

capybara-webkit doesn't work on Heroku

yeah definitely a +1 on breaking out a separate gem - when its ready add a url to the crawler's readme pointing to the repo, and the name of the...

Crawl the same URI requested by Google, so it works with HTML5 pushState

Yeah good call - I'll make hashbang / push state an option and modify Crawler.as_uri_with_fragment fn to use it appropriately

Crawl the same URI requested by Google, so it works with HTML5 pushState

Mate - any pull request you want to do would be greatly appreciated!