Benjamin Strasser

Results 28 comments of Benjamin Strasser

Same issue here.

Reproducible with `dagger 0.2.36 (ea275a3ba) windows/amd64`

The existing example(#3738) uses a non-public repository as a source for the SDK, which seems to differ from the current one in the main branch. Is #3719 and #3711 a...

I am not sure if simply parsing .gitignore files is sufficient as gitignored files are defined as followed: > A gitignore file specifies intentionally untracked files that Git should ignore....

As @vito said in [discord](https://discordapp.com/channels/707636530424053791/1037509195404169276) it looks like it is best to solve this issue by > running a git command to figure out the ignored files and then exclude:ing...

Maybe borrow the pattern from [hardhat](https://hardhat.org/hardhat-runner/docs/guides/deploying) to achieve exit codes and add this pattern to the examples and guides. This way the SDK just throws "better errors" and the user...

Another option is ``` connect(async (client: Client) => { .... }).catch((error) => { console.error(error); process.exitCode = 1; }); ```

@marcindulak I don't think you can currently use my approach since no Errors are thrown by dagger. Introducing sensible error handling is part of the discussion. Once sensible errors are...

> > Another option is > > ``` > > connect(async (client: Client) => { > > .... > > }).catch((error) => { > > console.error(error); > > process.exitCode =...

Opened draft here #3947