Benjamin Peterson

"finally" for futures

2

Consider the following simple snippet that does some work with a closeable resource: ``` Closeable c = allocateResource(); try { doWork(c); } finally { c.close(); } ``` If we want...

This leads to shorter code. It also allows using proto.Equal with a newtyped string field.

Make sure any internal buffers (especially compression) are flushed before attempting verify the digest of the downloaded file.

buildifier2

1

I'm curious what the status and purpose of buildifier2 is. Is it an experiment? Is buildtools planning to move to the Go starlark ast exclusively?

intended behavior of movePackageToTop

2

The implementation of `fix movePackageToTop` has a comment that suggests it will make the `package(` call the first statement after any comments: https://github.com/bazelbuild/buildtools/blob/b1667ff58f714d13c2bba6823d6c52214705508f/edit/fix.go#L401-L403 However, the implementation will put the package...

In ResultObject_Initialize, always borrow the conv dictionary from the caller. This simplifies the code, removes an allocation, and fixes ref leaks in error cases.

status code for unclean connection termination

14

When the TCP connection underlying a netty server connection is abruptly closed by the client, grpc-java goes through all active call streams and closes them as `UNAVAILABLE`: https://github.com/grpc/grpc-java/blob/6518d7bd6dc496c89ff320e06c73424f26af364a/netty/src/main/java/io/grpc/netty/NettyServerHandler.java#L613-L625 A problem...

iterating a closed response improperly produces data

6

Consider the following script: ``` import urllib3 http = urllib3.PoolManager() resp = http.request("GET", "https://www.python.org") resp.close() for d in resp: print(repr(d)) ``` With urllib3 1.25.7, this program prints `b''`. With urllib3...