Benjamin Grosse
Benjamin Grosse
+1 fixes windows
False positive on a non-nullable return type when there is some other nullable type in the return tuple that is constructed via function that returns pointer but is never nil:...
Could probably make some "preview" wrapper here that takes care of text and a `max-height`. Currently there is no Ueberzug support, but I am trying to add it. The PR...
> One question that I have is, will this pull in additional dependencies? Ideally, I would want joshuto (and `ratatui-image`) to continue to compile even if the user does not...
@DLFW I refactored the PR so that scripts are unaffected. There is however one breaking change. The `preview_script` hook, for textual previews, had a default value of something like `~/.config/joshuto/preview.sh`...
I can't get the `preview_shown_hook_script` stuff to work (on `main`). I could only get text previews to work with `preview_script`, and when that option (or the hook script option) is...
I added a commit that attempts the script first, and then renders as image. This way there are both text previews and image previews, and it's not a breaking change....
@DLFW sorry I forgot to add/undo the changes to `joshuto.toml` and `preview_file.sh`, pushed that now. The way it is now, this PR is not a breaking change (caveat: I could...
@kamiyaa yes. Sorry there was some mistake with ratatui's default-features in the crate, fixed now.
@DLFW thank you for testing this, and pardon me for not getting down to figuring out the existing hooks myself. I have now figured it out, at least for kitty,...