Ben Green

Results 36 comments of Ben Green

Thanks for leaving this comment - I had the same issue setting up my display. How far back did you have to go to get clear images? Now all I...

Hi @erikcs and @kanodiaayush, thanks for getting back to me so quickly! Please find below a screenshot of the tests @erikcs asked me to run. Not sure how to read...

Sure thing! Here it is. I tried to optimize performance for discrete / binned features as I think that's the modal case, but it looks like it performs very well...

Sure, here it is: ![image](https://user-images.githubusercontent.com/50080644/199067033-33b6ebee-325a-485a-8040-65ef3dba0a8d.png) This isn't what I expected to see, so I ran another flamegraph to try and diagnose where the policytree algorithm is spending time when creating...

Definitely looks to be the case - good catch! I am using a [BTreeMap](https://doc.rust-lang.org/std/collections/struct.BTreeMap.html) to create the sorted sets (which are converted to vectors once they have been populated with...

Sure - here are the benchmarks for depth-2 trees on the three datasets you describe. For the un-changed policytree: ![image](https://user-images.githubusercontent.com/50080644/199516235-f8d13c43-cc89-4ff6-a7f6-05caad1b4cce.png) For the policytree with the changes you described: ![image](https://user-images.githubusercontent.com/50080644/199516343-538b5efc-27e3-491c-ab1a-27416646d05f.png)

I've been running these on my laptop, but I can put them on my server. I don't know how long they will take, but I'll set them off and report...

Sounds good - I've set the code running again with just the Rust implementation going. Will likely still take a few days. The 250k observation run was based on dataset...

![image](https://user-images.githubusercontent.com/50080644/199641078-2bb94387-61af-4243-9bd1-a5d6c4c6002f.png) These came back a lot quicker than I anticipated! The binary and categorical runs both finished in about 15ms each for a dataset of n=100,000, while the dense dataset...