Benedikt Geisler comments

Results 11 comments of


                                            Benedikt Geisler

Should the logger create a Folder to store the text file if logger doesn't exist?

Hi, thanks for reaching out! Yes, I can reproduce this. The error returned by the logger is ``` 'Opening file failed. Error thrown by FB_FileOpen. Consult Beckhoff InfoSys. Internal Error:...

Performance

Good morning! This sounds reasonable. It also gets rid of empty strings in the error etc. which bothered me stylistically for some time: ``` _logger.AppendString('...').AppendAny(myInt).Error(''); ``` I'm a bit short...

Library Categories is missing

The library contains unit tests that use `TcUnit`. As the tests are directly part of of the lib it needs `TcUnit` as dependency.

API reference link broken in README

Hey! Thanks for reaching out! I'll look into this this weekend. As of now you can find the reference here: https://bengeisler.github.io/TcLog/reference/TcLogLib/Constants.html#sidetoggle

Roll file on size limit reached

Thanks for your feedback! Yes, I considered this policy but did not implement it due to time constraints. I'm open to contributions, though.

Usage with multiple tasks/cores

So far I have not tested this setup. And unfortunately, due to current time constraints, this is unlikely to happen soon. But I'll leave this open for discussion here. If...

NLog format ${longdate}|${level}|${logger}|${message}

Hi, did you try configuring the timestamp format as [described here](https://bengeisler.github.io/TcLog/userguide/configuration.html#timestamp)?

NLog format ${longdate}|${level}|${logger}|${message}

Hi, I'm a bit short on time so it's unlikely that I'll look into this soon but I'd be happy to review any PR for this.

NLog format ${longdate}|${level}|${logger}|${message}

Hi, no I did not work on this. I am open to reviewing PRs, though 🙂

Nuisance warning about signed conversion in TcLogCore declaration

Hi! Thanks for reaching out. This makes totally sense and should be easily fixable. I'll look into it.