Benedikt Deicke

Hi @abinoda! I can confirm that this doesn't work as expected and was able to trace it down to this line: https://github.com/jesjos/active_record_upsert/blob/24d7faaaf6ca63f987a870c0f6c47e02e8d50b48/lib/active_record_upsert/active_record/persistence.rb#L47 When using `.upsert!`, the attributes used in the...

No, `run_callbacks(:save)` runs all save related callbacks (before, around, after).

@jesjos The timestamps don't rely on callbacks right now: https://github.com/jesjos/active_record_upsert/blob/master/lib/active_record_upsert/active_record/timestamp.rb However, I still think this isn't a problem with callbacks, but with the way `.upsert!` handles the attributes that will...

With #75 in place, it's possible to implement this properly. However it'd be a breaking change. I'm happy to implement it, but I'd like to hear your opinion on how...

@olleolleolle Totally up to you. It’ll most likely take me a few days until I get to work on the callbacks.

The recent changes only fixed two issues, no backwards incompatible changes, yet.

We started seeing a lot of `ConnectionPool::TimeoutError` errors after upgrading to 7.1.2. Downgrading to 7.0.12 resolved the problem. Our timeout is at 1s as well, but it used to be...

@mhenrixon I don't think increasing `pool_timeout` is a necessarily a good solution. Yes, it might decrease the chance of getting `ConnectionPool::TimeoutError` errors, but wouldn't it also increase total execution time?...

It seems like #604 is adding using a `SidekiqUniqueJobs::TimerTask`, which under the hood uses a new Thread to repeatedly execute [`reaper_registered?`](https://github.com/Assa1121/sidekiq-unique-jobs/blob/12e698b441829b28c15509c1682bbd9495ef5238/lib/sidekiq_unique_jobs/orphans/reaper_resurrector.rb#L111-L115). This increases the total number of threads that use...

Upgraded to the latest version and disabled the reaper resurrector. No issues so far 👍