Ben Dilley
Ben Dilley
:+1: from me. I found this very helpful.
I'm more than happy to ditch this in favour of the Arel solution.
I just want to see if this version succeeds with activerecord 4.2 where #1022 does not.
Finally passing the tests. @guigs would you consider a SQL-based solution given that the Arel solution is not backwards-compatible with activerecord < 5? The raw SQL in this PR is...
Thank you @guigs for taking the time to look over this PR! I am currently on a different project from the one that's driving this change but will hopefully be...
@guigs I have added two new commits to cover your `Arel.star` suggestion and to account for calling `total_count` with a `column_name` - the latter was the most reasonable way I...
A lot of the Travis test failures for Rails 4.2 look like they're related 😞 Hopefully I'll have time to look at them soon...
It seems that `Arel::SelectManager.new` with no args is unsupported in activerecord 4.2 - it needs an `engine` but this arg is dropped entirely in more recent versions, i.e. there's no...
@guigs please see my latest effort with SQL as a fallback for ActiveRecord < 5. Setting the two solutions side-by-side like this hopefully demonstrates that they really are doing the...
I think you've come back round to #1012 @guigs 😅