benbenw

Results 14 comments of benbenw

Crypto#secureCompare : use the primitive type as the return value could not be null

no pb but due to java type boxing it should be backward compatible to the callers

Crypto#secureCompare : use the primitive type as the return value could not be null

> @benbenw sorry for the long delay on this. I'm just curious about what scenarios the return type could be null here. I see 2 places we return: > >...

WIP perf: Re-use buffer and char array when parsing jdbc sql.

I don't understand your question. :worried:

WIP perf: Re-use buffer and char array when parsing jdbc sql.

:disappointed: The application using statement or preparedStatement (or preparedStatement with highly dynamic query which make the cache nearly useless) has little interest in this discussion. I was clear in the...

WIP perf: Re-use buffer and char array when parsing jdbc sql.

> If a state is required, then why don't we just add a constructor to Parser class and use it accordingly? Because the parser is just a bunch of independent...

WIP perf: Re-use buffer and char array when parsing jdbc sql.

@bokken this patch is about parsing performance. I don't know why the discussion focused on sub-optimal applications. You can have a "quality" application with a lot of setReadonly true/false call...

WIP perf: Re-use buffer and char array when parsing jdbc sql.

rebased change the naming make the buffer holder less intrusive add comment

WIP perf: Re-use buffer and char array when parsing jdbc sql.

rebased correct the javadoc

Simple test of CachedQueryCreateAction#create

done + missing `@After`

Simple test of CachedQueryCreateAction#create

The query parsing / transformation in `CachedQueryCreateAction#create`.