Ben Schreiber

Results 6 comments of Ben Schreiber

@joleyjol this looks similar to #837 , does the fix there solve this issue as well?

@vakarisbk I agree 100%. I would also add two points: 1. Since the SparkSession used for executing SQL with Spark Connect is exactly the one we would use to execute...

@ssabdb Agreed that the there is a limitation; I think this is the key point: >Quite possibly that's an acceptable limitation but a potentially confusing one Additionally, since there are...

Here are two suggestions which came to mind: 1. The `args` parameter could be renamed. Something like, ```python def invoke(self, invocation_args: List[str], **kwargs) -> dbtRunnerResult: ... ``` Although, this would...

@dbeatty10 I agree with you that option one is ideal. I would extend it even further to update the method's signature to include `/`: ```python def invoke(self, invocation_args: List[str], /,...

Also, here is another/shorter monkeypatch: ```python from typing import List from dbt.cli.main import dbtRunnerResult, dbtRunner invoke_v1 = dbtRunner.invoke def invoke_v2(self, invocation_args: List[str], /, **kwargs) -> dbtRunnerResult: args_copy = list(invocation_args) kwargs_copy...