beltram

@raphaelrobert yes feel free to review when you are back. Failing tests are actually another issue (you will have exact same failure on main branch, it is unrelated to this...

All remaining comments addressed

> Thanks for the PR @beltram. Can you please have a look at the [contributing guidelines](https://github.com/openmls/openmls/blob/main/CONTRIBUTING.md) and update the PR accordingly? That should be in order now. If not please...

> More testing than just ValSem113, we need at least a full integration test for a group with multiple members Done [here](openmls/src/group/tests/external_proposal.rs) > * A stronger distinction between Add proposal...

@raphaelrobert > Feel free to re-request a review whenever you are done with the commits Sure I will do that in the future. I wasn't sure how I should reach...

> Not sure why the CI doesn't indicate it, but cargo doc fails for me. Fixed. I also missed in the CI, weird. > It's also weird that GH displays...

Hey, thanks for noticing. I've fixed it differently though, feel free to check it out

Hey ! Thanks for the kind words. Without further investigation I'm clueless. The standalone recorder is using [warp-reverse-proxy](https://github.com/danielSanchezQ/warp-reverse-proxy) so I bet there's some warp config to tweak in order to...

A little too complicated indeed. Have you tried [the solution](https://github.com/beltram/stubr/blob/0.5.0-rc.1/lib/tests/record/reqwest.rs#L9-L33) I proposed ?

No it's only sent once: `record()` takes care of sending the request. You would have to create another `AsyncRecord` trait and impl it for `reqwest::Client`. Have a look at [async-trait](https://crates.io/crates/async-trait)