Belisoful
Belisoful
This issue is holding up our issue: https://github.com/pradosoft/prado/issues/976
The price of making all properties accessible by magic method to one's own class, is making them publicly available to all. Contrary, Limiting the public to only public getters/setters limits...
https://github.com/pradosoft/prado/issues/898 This is the issue over on the PRADO side. I have a new `method_exists` that will fix the issue all ways. public access only for external objects and protected/private...
https://github.com/pradosoft/prado/commit/6296b7eb5185c118ab3ad8a8ed6e3b1cd791ab9c We fixed it.
it was about 10 ms slower on an 8.81s full run test. is that margin of error?
@My6UoT9 right, and there should be checks on access for public vs protected vs private via magic method.
All we had to do was change "method_exists" to "Prado::method_exists". It was assumed that there was some visibility validation when there was none. Our method does the visibility validation. simple...
and your comment is one reason I raised the issue here. for that feed back.
@notaidea If there is a public getter but not a public setter (or visa versa), using the magic method will still access the protected/private method. That is a violation of...
I suggest you run a `grep "protected function set" -r *` and see how much is incorrectly visible by magic methods.