Werner Henze

Results 10 comments of Werner Henze

From what I can see the major point in your examples is already handled by [F.56: Avoid unnecessary condition nesting](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f56-avoid-unnecessary-condition-nesting)!?

There are at least rules discouraging casts: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es48-avoid-casts, https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es49-if-you-must-use-a-cast-use-a-named-cast. I believe your suggestion would fit well into the [type-safety profile](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#prosafety-type-safety-profile).

Please note that the rule says "Avoid “magic constants”", not "Don't use "magic constants"". For example defining k0/k1/k2 for the indices 0/1/2 in your example looks like overkill. Maybe the...

@hsutter Can you please comment on the replies, especially of aligusnet and reddwarf69? That would help end the discussion (which just revived on the GSL repo). Also it is confusing...

Please also compare https://github.com/microsoft/GSL/pull/761.

Indeed, `SKIP_FUNCTION_MACROS=NO` makes this part work, but breaks other files. Shouldn't Doxygen do the same as the compiler and resolve all `#includes` and macros and so see if the class...

> You wrote: > Can you give an example of what is broken in other files? Yes. I am including `strong_typedef.h` from https://github.com/foonathan/type_safe and then get ``` warning: Found ';'...

[strong_typedef.h](https://github.com/doxygen/doxygen/files/8889269/strong_typedef.txt) > strong_typedef.h(813): warning: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon)

I know you find `void` return type useful when using `= delete`. Are there also other cases where one would use `void` return type? When would I want to disable...