Nikola Begedin

Results 93 comments of Nikola Begedin

# Proposed solution ## rename `conversations/conversation-part` to `conversations/conversation-part-comment` All related files ``` app/components/conversations/conversation-part.js app/templates/components/conversations/conversation-part.hbs tests/pages/components/conversations/conversation-part.js tests/integration/components/conversations/conversation-part-test.js ``` All references to those files - page object import in `-test.js` - `renderPage`...

# On the topic of authorization filtering on the client If it were a simple, quick check, I'd be fine with this. However, we are scoping our API. The API...

As I said in chat, I like the idea of specifying thread type. It could even be used for other potential features. There is an argument to be made, however,...

@daveconnis I looked into why your tests are failing. The reason is, the conversation models being created by mirage for the purpose of those tests are created without an associated...

@jderr-mx Sorry for the delayed response. It looks like you did some work on it either way, so it would certainly be good for creating a PR. At that point,...

This solves one half of the `"the instance initializer 'head-browser' has already been registered"` issue. However, the other half is that ember-cli-meta-tags also needs to update and use `[email protected]` internally....

I recommend not closing this PR, as we need to lookup the information here over and over again as the two problematic addons update.

Considering code-corps/code-corps-api#20 and the discussion therein, I would still consider this blocked by API, so I'll mark it as such. If someone wants to tackle the ember side of it,...

This fails due to what seems to be a reported issue in the ember-cli-head subdependency: https://github.com/ronco/ember-cli-head/issues/33 We should wait to see if there's any activity there before spending time trying...

@joshsmith @snewcomer I'm not the one who worked on it initially, so I'm not sure. My guess would be, the `index.html` ones are the default to fall back on, while...