Alexey Kirpichnikov

Придумали вот что. Сейчас такие нотификации уже есть, но они настраиваются через конфиг и присылают уведомления только "админам Мойры". Нужно вынести эту настройку в обычные подписки, чтобы любой желающий мог...

@iurimateus I think both your approaches fail to catch errors like `t1

I think, in this task we should try to catch as many expression errors as possible. Ideally, users should not be able to save an erroneous expression. And, as a...

@hv7214 these are two possible ways to make a broken expression, yes. But we need to validate all possible mistakes, not just these two.

@hv7214 okay. You can make a PR fixing these, and we'll try to come up with different ways to bypass your checks :-)

@usbulat I remember our talk :) We'll get to this task soon.

@borovskyav says it's planned for 2.5

Interesting places in code: 1. Rounding: https://github.com/moira-alert/moira/blob/a19b756b9ee9ef4f5ac3547e88e1dae688a2bb81/helpers.go#L195-L197 2. Also rounding: https://github.com/moira-alert/moira/blob/a19b756b9ee9ef4f5ac3547e88e1dae688a2bb81/metric_source/local/fetchdata.go#L94-L99 2. Data deduplication: https://github.com/moira-alert/moira/blob/a19b756b9ee9ef4f5ac3547e88e1dae688a2bb81/metric_source/local/fetchdata.go#L67-L69

An interesting case, when user erroneously sends points every 10 seconds instead of every minute. Let's say we allow rounding up within 10 seconds of the next timestamp. Original Timestamp...

> RoundToNearestRetention is kind of floor function No, it isn't. "Round to nearest" is not the same as "round down". And I'm not sure we can merge these functions. For...