Andrew Beekhof
Andrew Beekhof
Just make sure you run it through valgrind. There is some fun that happens between getXpathResult() and freeXpathObject() that was needed to make get_xpath_object() work. You'd better be sure it...
TBH, this scares the heck out of me. At the minimum, can we put this in a new agent (source the original then add the new functionality)? I can see...
I found myself nodding furiously to this comment from @rickardp > Specifically, the sentence saying "when the user says to dry run, respect the user's wishes and do not connect...
FYI @mshitrit
What about this instead? ``` diff --git a/pcmk/fence_compute b/pcmk/fence_compute index 34c2ed1..be88639 100755 --- a/pcmk/fence_compute +++ b/pcmk/fence_compute @@ -116,6 +116,10 @@ def set_power_status(_, options): on_shared_storage = True else: on_shared_storage = False...
seems reasonable. @aspiers ?
I'm with Marc on this one, operators should not modify the spec. If the value is missing or too low, either: 1. refuse to start (taking advantage of crash-loop-backoff) 2....
No objection, but if you need to fall back to 2 or 3 anyway... why not always use that mechanism?
I can see what this does, but not why - though I'm not sure where the best place to keep that information. Maybe a PR against the docs repo that...
@day0hero this seems like a nice improvement, any reason we shouldn't merge this? should it be on all deployments or is it more an optional thing?