Benjamin Eberlei

icon indicating a website link https://beberlei.de

icon company Tideways GmbH icon location Germany icon location Founder of @tideways, PHP performance monitoring, profiling and exception tracking software. @doctrine core member and occasional @php contributor

Results 139 comments of Benjamin Eberlei

CssRewrite goes through app_dev.php in Symfony

I am using the following twig commands: ``` {% stylesheets 'bundles/hwsplatform/lsl/css/layout_3col_fixed.css' 'bundles/hwsplatform/lsl/css/stylesheet_168fd464f0.css' 'bundles/hwsplatform/lsl/css/fix_glossary_definitions.css' 'bundles/hwsplatform/lsl/css/lsl.css' 'bundles/hwsplatform/aristo/jquery-ui-1.8.7.custom.css' output='css' filter='cssrewrite' %} {% endstylesheets %} ``` In dev mode this becomes (and so on):...

CssRewrite goes through app_dev.php in Symfony

Ok, same happens for image rewrites of course. Which 404s them aswell.

alnum() misleading, should use ctype_alnum()

ctype is locale dependent, all our code does not depend on environment right now.

alnum() misleading, should use ctype_alnum()

@webmozart See http://php.net/manual/en/function.ctype-alnum.php its reference to "default locale" and the link to `setlocale`.

alnum() misleading, should use ctype_alnum()

its not really a breaking change, because we are making the validation less strict. Making it stricter would be a problem though. I consider this a bug, if alnum actually...

use a string wrapper to support intl, mbstring and iconv extension

@sandrokeil I am unsure, it must be a new major version that is for sure, but i don't know if intl is as widespread as mbstring.

Added isCallable, propertyExists, propertiesExist, keysExist, date, utf8

These are too specific for my taste. I am not sure to add them,

Conventions for the integer constants in Assert\Assertion

Its free for all :)

Add support for package type

@marcospassos If you can keep the patch small, then yes. But I feel that is not possible from what I understand about the potential ramifications. The likelihood of me merging...

the doc about the way to reference third-party packages in monorepo.json is wrong

Isn't `vendor/symfony/symfony` relative to the root of the repo? That at least what i mean here. Currently only working with the default `vendor/` is supported.