Bhavesh M

Results 13 comments of Bhavesh M

Hi, can I work on refactoring DocLink.tsx?

Hi, is this issue available to work on?

Thanks! Correct me if I'm wrong but if I wanted to make a pull request adding the least connection load balancing algorithm to pingora, I'm assuming I would have to...

Hi, can I work on this issue?

@zulinx86 I've refactored the snapshot module code based on the pattern provided and wanted to check in with you to make sure I'm heading in the right direction. Let me...

Hey @zulinx86 @roypat @ShadowCurse, I opened up #4691 as a draft PR. Any feedback on it would be great. I apologize for the inactivity but I'll actively work on it...

Sorry, I missed your previous comment. My two questions are whether the snapshot module I rewrote matches what you were expecting. I also refactored some of the existing snapshot code...

Messaging to let you know I'm still working on this

Hi, yeah I still am. I'll push commits addressing your comments and a few other changes in the next couple days.

Hi @bcardosolopes, I believe the discrepancy is because of [this](https://github.com/llvm/clangir/blob/0ae5000413dfa2022fafa8b523864d3f034d0ac3/clang/lib/CIR/CodeGen/CIRGenModule.cpp#L1203) block (lines 1203 - 1214) in `CIRGenModule.cpp`. I'm new to ClangIR and was wondering if this was a good issue...