Brian Durand comments

Results 12 comments of


                                            Brian Durand

set master only for write operations

Your config is specifying `:all => :master` which will force using the master connection. Try changing to `:all => :persistent` to have the read pool be the default.

Logging of connection?

I can't see any good way of adding logging that would work across database adapters and that wouldn't be too chatty. You could mix in something to you specific connections...

Making Seamless Database Pool work with Thinking Sphinx

I'm not sure what side effects there may be in reporting the underlying adapter class name for the class name of the seamless database pool adapter. I did just add...

Issue with update_all

Can you capture the SQL generated with and without the gem installed from your development logs.

various improvements

Those changes sound reasonable. Go ahead and add the tests.

Document not found error with Mongoid

How are the models not able to be deleted?

any reason for removing 'join' method on Lumberjack::Device::Writer::Buffer ?

In the last release I optimized the thread synchronization to reduce lock contention. There was no particular reason to remove `join` other than it wasn't being used internally anymore (and...

Log file permission attributes

Is it the archived file that ends up with bad permissions or is it the live log file?

Image align styles not being retained when they are already set

I figured out the core issue is that there is a whitelist of allowed attributes on the image tag and style is not one of them. See https://github.com/quilljs/quill/issues/1556

Aggregate saved changes for all updates inside of a transaction

@rafaelfranca I would agree that it is not ideal. I've moved the bulk of the code to `active_record/attribute_methods/dirty.rb`. I still needed to hook into the code from the transactions code...