Brian Ferris
Brian Ferris
As an update, my colleague @asvechnikov2 has put together a proposal doc that describes potential high-level functionality in support of custom validation: https://bit.ly/gtfs-validator-custom-validation Happy to have feedback (heads-up @KClough @themightychris).
I wasn't quite sure what you were asking here. Are you asking if we want to contribute an implementation for this validation check? Or if we had an existing implementation?
Initial draft, mostly to see what happens when validating a few existing feeds.
Now that #1248 has been committed and integrated, this PR is ready for official review.
I believe @isabelle-dr was correct that I didn't have a validation check for when `duration_limit_type` was specified but `duration_limit` was not. I've added that now. I believe all validation rules...
I was looking at the acceptance test implementation and I noticed that there is apparently [code in the acceptance_test.yml](https://github.com/MobilityData/gtfs-validator/blob/master/.github/workflows/acceptance_test.yml#L185) to post a comment to the pull request with acceptance test...
Well, we can definitely improve the acceptance test without fixing the comment issue. That said, I was looking at [this method in the comparator](https://github.com/MobilityData/gtfs-validator/blob/master/output-comparator/src/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/Main.java#L221) and I think it could definitely...
So a couple things now that I've had a chance to run #1228 against the feeds in the validator acceptance check. * There are a significant number of feeds that...
Regarding currency amounts, that's correct: they do not have the number of decimal places required. Regarding backwards compatibility, I think this is a little subtle. Per the [Guiding Principles](https://developers.google.com/transit/gtfs/guides/guiding-principles), backwards...
I have a question about the proposed behavior of the web service: would the service be synchronous? Namely, when a validation request is submitted to the service, would the API...