Brent Christian comments

Results 6 comments of


                                            Brent Christian

8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher

/sponsor

8314480: Memory ordering spec updates in java.lang.ref

/label add hotspot-gc

8314480: Memory ordering spec updates in java.lang.ref

AFAICT, all review feedback on this change has been addressed. I would love to have some reviewers take another look. Thanks!

8314480: Memory ordering spec updates in java.lang.ref

> @bchristi-git Just checking in—we're waiting for CSR-approval here before integrating? 🤔 Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer ✔️s. 😉

8314480: Memory ordering spec updates in java.lang.ref

/integrate

8333396: Performance regression of DecimalFormat.format

(Same comment as on the [other PR](https://github.com/openjdk/jdk/pull/19534#issuecomment-2148568212).) Would it be better if the benchmarks returned the created DecimalFormats ? Just thinking about dead code elimination: https://github.com/openjdk/jmh/blob/master/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_08_DeadCode.java