Brian Brookman comments

Results 5 comments of


                                            Brian Brookman

Make apiserver port user-configurable

Added an additional commit to add FQCNs for builtin actions and pass the lint check.

fix: ensure indent-seq works in nested collections

Hi @adrienverge, thank you for reviewing and so sorry it's taken me this long to respond. The only corner case I can think of that this might impact is for...

With complex nesting, wrong indentation isn't caught for all items

I dug into this and found that it's related to the arbitrary expected indent value of 2 set when a block sequence should be indented, but the expected indent value...

volumeMount and NFS mount clash when trying to use NFS for primary data storage

I've also been trying to get this to work. As you alluded to, it's because the value of `nextcloud.datadir` is always used as a mountPath here: https://github.com/nextcloud/helm/blob/36118d09cf6f95b7f83a8641f23ac8362e079913/charts/nextcloud/templates/deployment.yaml#L222-L230 I expect changes...

volumeMount and NFS mount clash when trying to use NFS for primary data storage

Thanks for the responses! I did see `persistence.nextcloudData.existingClaim` initially but hadn't considered it with an NFS volume. As @Heavybullets8 mentioned, using it with an NFS PV should work