Theo Li

Results 12 comments of Theo Li

测试挂了,还得对应的改一下测试

代码没问题,但涉及到一些别的库需要的同步更新,暂时不合进去

还需要在 walk 等函数上实现 followlinks

Looks like if there is a customized metaclass for class A, it won't be treated as Generic?

😂 想了想对这个需求,最麻烦的地方是,megfile 没设计自己的配置文件,alias 没地方存 实现路径似乎可以是 1. 设计一个 megfile 的,或者仅仅是 alias 的配置文件 2. 设计个 AliasPath,是其他 Path 的一个简单 wrapper

> 叫 `DEFAULT_WRITE_BLOCK_SIZE` 好点吧,默认等于 `DEFAULT_BLOCK_SIZE`,没大文件需求还是块小点好,能多利用多线程以及 retry 的成本不高。然后我准备再加个 `DEFAULT_READ_BLOCK_SIZE` 这样读写都可以自定义。相关的东西我在文档里面好好描述一下 好,我改一下,主要看到 `MAX_BLOCK_SIZE` 也是写相关的

总算都过了 😂 费了老鼻子劲

修了下上面的 review comments,彭老师眼神真好 👍

There all tons of old .ppt files in the world, it would be great if `markitdown` can convert them to markdown, just like what it did for .pptx files *...

@beeshankar Indeed, I realized what you mentioned by observing #153 . I think I can solve the problem using the libreoffice (or sth. like that) plugin for MarkItDown. If this...