Bryan Boreham
Bryan Boreham
I filed this when I was helping out at an AWS training event. Not planning to go through it again soon; suggest you get anyone at the next training to...
> PR 2702 and the methodology taken there is inherently better at handling high number of groups than the current methodology used to compute usage groups Yes, usage groups are...
You tried the test at the commit I linked?
Elsewhere, we extended `DeepEqual` with a couple of features. Via tags: https://github.com/weaveworks/scope/blob/477f6782f4622451723b2856bea49dca64052e53/test/reflect/deepequal.go#L146-L149 and to call a `DeepEqual` method if defined on the values: https://github.com/weaveworks/scope/blob/477f6782f4622451723b2856bea49dca64052e53/test/reflect/deepequal.go#L60-L66
Sorry I did not notice this previously. #12048 and #12084 are changing the same code, probably for the same reasons. I ran the benchmark added in this PR at commit...
Update: when I profile the benchmark in this PR I see it spends most of its time reporting an error "no address". I attempted to fix the obvious problem and...
Can we close this? Anything left that I didn't address in https://github.com/prometheus/prometheus/pull/12048 and https://github.com/prometheus/prometheus/pull/12084 ?
If the context is replay of WAL after a restart of Prometheus, then these are not "retries" as the word is used in the remote-write code. You may find the...
The `loadgen` process is running more queries in a given time, because they are succeeding faster. So the increased CPU is not a regression.
/prombench cancel