Bryan Boreham

Agreed. Couple more points at https://github.com/cortexproject/cortex/pull/3654#issuecomment-763006285 I couldn't see an existing issue in the Prometheus repo so opened https://github.com/prometheus/prometheus/issues/8418

The necessary part is now implemented in Prometheus https://github.com/prometheus/prometheus/pull/8237 (and made optional in https://github.com/prometheus/prometheus/pull/8477). I'll leave this open until Cortex sends the `retry-after` header to make it slow down an...

Same issue hits when you have more than 3 ingesters, one is LEAVING, and another one goes bad. Distributors will fail the entire request back to the sender with a...

#4626 is another issue; did you mean #4636?

I'm a bit confused why files disappeared like `pkg/chunk/purger/tenant_deletion_api.go` and the why the blocks purger is under `pkg/chunk`. Did any functionality disappear? Could the blocks functionality live under `pkg/storage/tsdb` ?

> I just combined both under one file and called it the blocks purger This would be a good thing to explain in the PR description, to aid reviewers. Also...

I expect when we remove chunks support (which is deprecated), then we can delete `pkg/chunks`, so don't add anything blocks-related under there.

Can you explain the distinction between "delete request" and "tombstone" as used in this code?

Adding to my earlier comment, the `TenantDeletionAPI` which only works on blocks was previously added under `pkg/chunk/purger`, so it was already confusing. It's really hard to follow when you add...

I would really prefer not to do this: binaries inside containers are useful to attackers. Really we should be going distroless. I couldn't follow your reasoning why this is necessary;...