Bartosz Bonisławski

Results 10 comments of Bartosz Bonisławski

Thanks @pavels for your contribution, I really appreciate your help. Could you rebase against current master and add some regression spec?

There is failing test caused by your changes too. Please update it

Hello @himanshumishra31 , I'm really grateful for contribution but can you explain motivation behind changing it?

I think that this is outdated already. If you think that it's not outdated, please mention me in comment and I'll reopen it

@kushniryb yeah. I have no idea why did I close it o.O

@damianlegawiec Can you check it now after fixes?

Did you remove `//= require spree/frontend/spree_auth` from vendor/assets/javascripts/spree/frontend/all.js? and check config/initializers/devise.rb if there is something connected with spree_auth_devise

Hello @cmrd-senya , thanks for your contribution. It's best to use `redirect_back` method from rails instead of implementing it yourself. Since we support both rails 4.2 and rails 5.x we...

``` 2.5.1 :001 > Spree::V2::Storefront::ProductSerializer.new(Spree::Product.first).serialized_json => "{\"data\":{\"id\":\"1\",\"type\":\"product\",\"attributes\":null,\"relationships\":{\"variants\":{\"data\":[]},\"option_types\":{\"data\":[]}}}}" 2.5.1 :002 > Spree::V2::Storefront::ProductSerializer.new(Spree::Product.first).serialized_json => "{\"data\":{\"id\":\"1\",\"type\":\"product\",\"attributes\":{\"id\":1,\"name\":\"Ruby on Rails Tote\",\"description\":\"Accusamus nisi quia eaque quod magnam reiciendis. Deserunt quod velit excepturi perspiciatis. Aperiam fugit molestias...

I've done more investigation and it's definitely connected with this https://gist.github.com/rsutphin/5102133 and https://github.com/Netflix/fast_jsonapi/blob/dev/lib/fast_jsonapi/serialization_core.rb#L76 `any?` called on activerecord collection somehow calls `break` underneath and whole hash becomes `nil`. Simple fix that...