Branden Bonaby
Branden Bonaby
FYI @PlagueHO, thanks! I'll work on an integration test for this in the mean time
*[`source/DSCResources/DSC_Disk/DSC_Disk.psm1` line 283 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_TkGO2De8o2Q7v3n-:-NhmcLWI0JVYMKLQrmEd:b2fbntx) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_Disk/DSC_Disk.psm1#L283)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… I noticed this was removed in the previous PR (DevDrive) - is this intentional? oh actually this can...
*[`source/DSCResources/DSC_VirtualHardDisk/DSC_VirtualHardDisk.schema.mof` line 5 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_WBPHCPEQZx09baZn:-Nhmk3Fl0PKqzzDTiYsD:b-xlfnfb) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/DSC_VirtualHardDisk.schema.mof#L5)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… "created _or_ attached" - should this be "created and attached" ? E.g., is there a way this resource...
*[`source/DSCResources/DSC_VirtualHardDisk/DSC_VirtualHardDisk.schema.mof` line 9 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_Xa0q70vF4du90_ja:-Nhmm5HV7B5ai3zM_00C:b-xlfnfb) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/DSC_VirtualHardDisk.schema.mof#L9)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… nit: should not be attached -> should be detatched if it exists. thanks updated
Updating this today to resolve the merge conflicts and address the initial comments. Looks like I prematurely replied to your previous comment so sorry about that. I'll keep them as...
*[`source/DSCResources/DSC_VirtualHardDisk/README.md` line 9 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_Wr7Q0XXloZIuR1ZX:-NhoUZK_5XVsV_lqawGf:b-jxphqv) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/README.md#L9)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… Will the resource attach the virtual hard disk if it is not attached? updated and clarified the behavior...
*[`source/DSCResources/DSC_VirtualHardDisk/README.md` line 11 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_WVXG9S5cyhsIdSbP:-NhoUeQiCh0RUtcZOSOH:bxzjjx0) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/README.md#L11)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… If the real vhd/vhdx exists but is not attached, but the size and/or disktype is different, what happens?...
*[`source/DSCResources/DSC_VirtualHardDisk/README.md` line 28 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_VHpH8_RkQboxsCzQ:-NhoUoOt-4RwE_7QZiot:b-febffi) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/README.md#L28)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… Can we add a warning here that using both DSC_VirtualHardDisk and DSC_VHD in the same config/machine could result...
*[`source/DSCResources/DSC_VirtualHardDisk/README.md` line 33 at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_VuFL-VFWonVod1E8:-NhoV1UWCr0F59L37I8P:bjcogm5) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/DSCResources/DSC_VirtualHardDisk/README.md#L33)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… See comments about markdown autonumbering above. Can also use the VS Markdown linting extension to automatically get this...
*[`source/Modules/VirtualHardDisk.Win32Helpers/VirtualHardDisk.Win32Helpers.psm1` line at r3](https://reviewable.io/reviews/dsccommunity/StorageDsc/279#-Nh_UC5Q8SJmxE9yFVay:-NhoVAYn5ZLDw5M-ecvF:b-fdapof) ([raw file](https://github.com/dsccommunity/StorageDsc/blob/937e81fd6a17144227787fa515334d1f2b0af3d1/source/Modules/VirtualHardDisk.Win32Helpers/VirtualHardDisk.Win32Helpers.psm1#L)):* Previously, PlagueHO (Daniel Scott-Raynsford) wrote… To help associate any imported modules with the DSC resource, can we name this as `StorageDsc.VirtualHardDisk.Win32Helpers` - or something...