bbist

Results 13 comments of bbist

Hi @sink772, Did you have some time to review this, it'd be great to continue the discussion. We have some comments in our CPS proposal, where validators seems to want...

Hi @MuhammedIrfan, Can you try with the [latest changes](https://github.com/icon-project/icon-bridge/pull/545/commits/1915df5fb0d8bdab6d644444c1aa1dc59142f1ac)? You need to provide a configurable value for `tx_data_size_limit` from the config file as [specified here](https://github.com/icon-project/icon-bridge/pull/545#discussion_r979928262).

> These changes need tests. Thanks @CyrusVorwald-ICON for pointing it out. It wasn't a final solution, but rather an intermediate one to see if it works for NEAR. Anyway, I'll...

Hi @MuhammedIrfan, The [tests that were failing on near side](https://github.com/icon-project/icon-bridge/actions/runs/3148528467/jobs/5119161474) were not implemented correctly. I've changed the test parameters so that they work as expected. They should work now.

> Hi @MuhammedIrfan, > > The tests that were failing on near side were not implemented correctly. I've changed the test parameters so that they work as expected. They should...

> @bbist looks like it does not add message to tx if rlp size is more than configured limit also if it have only 1 event Yeah. That's true. You...

> > > @bbist looks like it does not add message to tx if rlp size is more than configured limit also if it have only 1 event > >...

> @bbist > > > in the worst case, it'll forward 1 event. This is what we did for BSC. If this approach is sufficient, then it's fine. Otherwise, we...

> > @bbist > > > in the worst case, it'll forward 1 event. This is what we did for BSC. If this approach is sufficient, then it's fine. Otherwise,...

@andrii-kl, can you check if the txn gas limit being assigned is below the block gas limit? If you're using default settings, please enforce a manual gas limit below block...