Bryan Beaudreault

Results 39 comments of Bryan Beaudreault

@cbaenziger thanks for the input. I made changes per your request. Here's the updated format: ``` Key length: min = 29 max = 29 mean = 29.00 stddev = 0.00...

@rda3mon is this ready for review?

Yea, the spotbugs issues look related to the recent spotbugs version upgrade. I think they will be tackled in https://issues.apache.org/jira/browse/HBASE-27373.

Unfortunately only committers have access to the build server. I kicked off a rebuild last night. The easiest way for you to self-service this is to push a commit. Sometimes...

@rda3mon I know this is still just a draft, but can you address the error-prone findings in the pre-commit? Shows up under javac: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt Can you do it in a...

@rda3mon I find that the violations are usually pretty straightforward. If there are any that you have a question about, feel free to post here. I do think it's possible...

@rda3mon looks like that cherry-pick resolved most of the error prone issues. Looks like there are 3 left: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt They look pretty simple/javadoc related. would you mind pushing 1 more...

Sorry for the delay here. We are currently evaluating internally in our fork. Will get to reviewing in the near future.