Barry Evans
Barry Evans
Hi @robinmanuelthiel and @madnuttah I have been looking at this repo too and I want to introduce a similar change to supply a hostname (with `-o` argument) to the `speedtest`...
> > p.s. the similar change I made can be found at > > > > * [bazzani@2033353](https://github.com/bazzani/speedtest/commit/2033353a1b671a3be0b7de876376f49c2cbe9568) > > This looks promising. Can you create a PR from your...
> Yes, exactly. To me it's important, that I also works without specifying any server name or IP. 100%, I will open the PR soon enough, after giving it a...
I also have another WIP change in a feature branch that uses the Dockerfile to build the speedtest image in the docker compose file, rather than the image being pulled...
> @bazzani Not sure, if I like the build part in the Docker Compose file, as I wanted to give an example, how to use the container easily in Docker...
> Hey there and sorry for my late reply. I must confess this was quite rushed. It was working so I submitted the PR without any further tests, as I...
> @bazzani, are you still planning to create a PR for the Server ID? Hi @robinmanuelthiel i am indeed. I started working on it last week and got stuck on...
FYI @robinmanuelthiel @madnuttah PR opened #19
Nice to be able to contribute @robinmanuelthiel... there are a few more enhancements I would like to propose, I have opened a new PR just now.
I think this other change was introduced to help with error handling - 1f3c8db8 - but it relies on the container failing and being restarted (the logic is in the...