Yuichiro Yamashita

Results 190 comments of Yuichiro Yamashita

This way will eventually register all of interfaces of `lib.dom.d.ts`, but should we go this way? https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts

Close in favor of https://github.com/sveltejs/svelte/pull/7786 Thank you for your contribution @elamje !

@tanhauhau I created PR. https://github.com/sveltejs/svelte/pull/7869

For part of users, this change increases runtime js size. Would it be better to provide another function?

Personally `slideX` is ok for me, but I'm not professional in stylish naming, so I want to wait for more maintainers or naming professionals' comments.

related issue: https://github.com/sveltejs/svelte/issues/7454

Since Action receives an HTMLElement, so it cannot follow below rule. https://svelte.dev/docs#run-time-svelte-onmount > It must be called during the component's initialisation I have implemented an alternative. Would this be a...

`` tag's `height` attributes should set a number. Therefore at this line, maybe a browser (e.g. Chrome) ignored that is not number value. https://github.com/sveltejs/svelte/blob/7b7c312801327e7a05983af97d863d9319043d58/src/runtime/internal/dom.ts#L305 By the way, @Conduitry mentioned this...

Close in favor of https://github.com/sveltejs/svelte/pull/7786 Thank you for your review @bluwy !

I think this PR will fix the issue. https://github.com/sveltejs/svelte/pull/7260