Philip Ross

Results 8 comments of Philip Ross

Check Encodings before calling force_encoding in Addressable::URI

@dentarg I have rebased and updated this PR. Let me know if theres anything else you want me to change.

Check Encodings before calling force_encoding in Addressable::URI

@dentarg This is ready for review again

Server terminating: Package {"hexpm", "spandex"} not prefetched, please report this issue

Hey, I was gonna take a crack at seeing if I could fix this (I had this issue reproducible about a month ago, but alas, it no longer reproduces (my...

Digest is ~5x slower on Ruby 3.x then 2.x

Heres a gist of what I was personally using to benchmark: https://gist.github.com/baseballlover723/c02a6f803ac4147585d183d0430b205e. It might be useful to you all.

Digest is ~5x slower on Ruby 3.x then 2.x

So people who want the higher performance of the Ruby 2.x version on ruby 3.x should just switch from using `digest` to `openssl` to keep using the same implementation as...

Propagate mixfile errors to the user better.

Hi, I don't work with Elixir anymore, so I'm not sure if its still an issue. I would presume so, if there haven't been major modifications to the hex part...

Propagating `@compare_by_identity` and `@block` in `Hash`'s methods

What is even the correct behavior with `transform_values`? It seems that ruby doesn't actually copy over the default value for `transform_values` (edit: or for the other ones either, though I'd...

Propagating `@compare_by_identity` and `@block` in `Hash`'s methods

I just ran what ruby does regarding default values for these and this is what I got Method | Ruby | Crystal -- | -- | -- #dup | ✅ ...