balsa-sarenac
balsa-sarenac
Hello, thanks for the feedback! This popup occurs only when there are changes that could break the code. For example, we show the warning if the method is still used...
Ah, I got it now. I understand your stance, we were moving in the direction of having all refactorings act in a similar way and therefor showing this confirmation before...
I don't think that proposed solution is in line with how other refactorings create changes. We should look into `self definingClass` and also `#compile:classified` and see why the change is...
I meant that we never call `#addChange:` directly in the refactoring. Doing it like that would be a hack. We should investigate and figure out why exactly the model doesn't...
Hey Hernan, where did you discover this bug, how can I reproduce it?
@hernanmd we debugged and the fix is: ``` RBMakeClassAbstractTransformation >> privateTransform self generateChangesFor: (RBAddMethodTransformation sourceCode: 'isAbstract ^ self == ' , targetClass asString in: targetClass classSide withProtocol: #testing) ``` previously...
This is now fixed
Look at #16125, now named `#isEssential` and `#isUsedAsReturnValue`
Let me know what to do fix/remove, and I'll create a PR.
I looked at the `Spec` and it says that this can be removed one `defaultSpec` is migrated to `defaultLayout`. Now `defaultSpec` has no senders, but there are no deprecations or...