Burak Akgerman
Burak Akgerman
I submitted a PR for review for this
> Could you please add some tests? > > maybe helpful: https://stackoverflow.com/questions/59583406/how-to-unit-test-a-net-middleware-that-uses-response-onstarting Certainly, thank you for the link. I was looking for the existing unit tests for the ASP.NET version...
Will need to determine why Write method in the target sees a null HttpContext if this is due to unit test only or if this fails in actual application. Will...
I have made a commit so that the http context is saved into an httpcontextaccessor upon begin request, so that the http context is available during the write method. Since...
> yes unfortunately any strange aspects of the original may exist in this one. I was myself unable to understand how this will work in concert with the existing AsyncTargetWrapper....
Added a commit so that the asp.net and asp.net core version both use a common base class, so no more duplicated code.
The code for ASP.NET and ASP.NET Core is now 95% the same in base classes.
> @bakgerman Curious if you have ever used this code on ASP.NET Core Application? Or if you are just picking up a challenge? > > I'm guessing the goal of...
> Think it would make most sense if there was only one `AspNetBufferingTargetWrapper`, but depending on target-platform, then it hooked up to Http-Module or Http-Middleware. Maybe the Http-Module and Http-Middleware...
Thank you snakefoot for the pull request to close this issue.