Jinwoo comments

Results 16 comments of


                                            Jinwoo

Extend fetchSize support across JPA Item Readers

@fmbenhassine Thanks for checking out my PR. But I can't seem to find the inline comment you're talking about. Can you point me in the right direction?

Extend fetchSize support across JPA Item Readers

@fmbenhassine Thank you for your review and feedback! I'll update the PR to use ```Map hintValues``` for setting hints, ensuring the JPA reader remains implementation-agnostic.

Extend fetchSize support across JPA Item Readers

@fmbenhassine I've updated the PR to include a Map hintValues for hints, similar to our approach with query parameters. This change ensures our JPA reader is implementation-agnostic, allowing users to...

Add gzipDisabled at the ResponseDefinitionBuilder level.

Hi, is it okay if I contribute to this issue?

Add methods to augment allowed headers and parameters in StrictHttpFi…

Thank you for the review, @jzheaux. However, since the setters are not static, would it be acceptable to change them to public instead of public static?

Add methods to augment allowed headers and parameters in StrictHttpFi…

Thank you for the feedback, @jzheaux I have updated the `StrictHttpFirewall` class to change the private Predicates for allowed header names, header values, parameter names, and parameter values to public...

Add methods to augment allowed headers and parameters in StrictHttpFi…

Hi @jzheaux, Sorry for the late response. I've made the changes based on your feedback. PTAL. Thanks!

Make trailing slash removal the default

Hi @OlgaMaciaszek, I'm interested in this issue and would like to contribute. May I give it a try?

Make trailing slash removal the default

Thank you, @OlgaMaciaszek! I understand. Please feel free to ping me when the time comes. I’d definitely like to try it.

Allow a StepInterruptionPolicy to be injected through the step builder

Hi @fmbenhassine Can I work on this?