Minbo Bae
Minbo Bae
The current fix for `ProtoMessageSchema` uses `hasField(FieldDescriptor)`, but it's not efficient. I've just realized that a scalar field with "presence" has a `has` method. I'll use `ByteBuddy` to make more...
> I haven't finish a full review but I have two big picture comments: > > 1. The amount of `@NonNull` annotations is suspicious, since this is the default. You...
I've cherry-picked the commit at https://github.com/apache/beam/pull/35217. Thanks!
Run Java PreCommit
@kennknowles could you please proceed with the review when you have time? Thank you.
Run Java PreCommit
> I haven't gotten to make another pass yet. I did just look at the tests and there is a prism failure which is pretty rare. I restarted the test...
I've removed `@NonNull` and `@Nullable` from generic types in the `ProtoBeamConverter` class. I realized I had significantly misunderstood their proper usage. Nullability annotations on generics are only for specific use...
Run Java PreCommit
Run Java PreCommit